Simplify closureForState in epsilon closure#550
Merged
Conversation
Pure code-motion cleanup of closureForState; no behavioral or performance change (interleaved benchstat over the build path shows no significant difference in time/bytes/allocs). - Hoist state.table.isEpsilonOnly() into a single named local (selfWasCollected), replacing three separate calls each re-explaining the same epsilon-only caveat. - Extract the table-share dedup post-pass into dedupByTableShare, shrinking closureForState to its core narrative and isolating the unsafe.Pointer share-group logic. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
timbray
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't change anything structural, just makes it easier to read. See #549.
Pure code-motion cleanup of closureForState; no behavioral or performance change (interleaved benchstat over the build path shows no significant difference in time/bytes/allocs).